CHICKEN Packaging #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I also fixed everything to just use spaces since it appears there was mixed indentation in the file itself.
Note that for some reason one test fails. This is the final test, which fails because `(fake-salt-hash #t)` is an error (the procedure doesn't exist). I imagine it has been removed or existed only locally. I have no idea of its origin.
It is a compilation artefact and isn't worth keeping since it is generated when the egg is compiled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the legwork and files necessary to package SRFI-128 for CHICKEN Scheme, and incorporate it into an egg (CHICKEN Extension). Everything works without fail, with the exception of one test in the
comparators/comparators-test.scmfile. The failing test is the final one, which fails because calling(fake-salt-hash #t)is an error. I do not know the origin of this test or what it is supposed to mean, but outside of that everything should just work.NOTE: A LICENSE and README are added as well, to explain the licensing as well as what the extraneous files in the repository are if people come to visit the repo and wonder what the meta, setup, and release-info files are doing.
Lastly, if this is merged, could you please add a tag to the repo on Github so that we can include it as a CHICKEN extension? Should be as easy as:
Whether you want to annotate that tag or not is up to you (
-aoption forgit tag).